Luke Lowrey

Results 12 comments of Luke Lowrey
trafficstars

Hi @ur3an0 thanks for the PR. Just wondering if we should support this functionality via a template renderer (ITemplateRenderer) rather than sender. What do you think?

I'll get this one merged in shortly. There are some conflicts on the version.

Hi @belidzs and @klevisndoka I am going to find time in the next week to review all these PRs and get a new release going. Thanks heaps for your work...

This is very similar to #204 . I suggested maybe a renderer is the best option (though we might have to change some core core)

Hi all, If you have something tested and working open a PR and I will try get it merged in. Luke

Attachments need to be handled in the ISender implementation. There is an example in the SendGrid sender here: https://github.com/lukencode/FluentEmail/blob/4b9740bb1b1df9750f0d7043f6ca6c72bc39b86f/src/Senders/FluentEmail.SendGrid/SendGridSender.cs#L100 Not sure what sort of CSS embedding you want to do....

A new package for the AWS sender is a good idea. Happy for it to be part of the core FluentEmail repo or separately maintained. I think the FluentEmail template...

Sounds good @Simonl9l The Razor renderer does support using layout files to achieve that sort of thing but it is in need of an update to clean everything up.

Hi @belidzs thanks for the PR. Do you think this functionality is better implemented when setting up the MailGun sender eg: ```csharp var sender = new MailgunSender( "sandboxcf5f41bbf2f84f15a386c60e253b5fe9.mailgun.org", // Mailgun...

Sweet, will see if I can take a look this afternoon