Luca Kellermann

Results 102 comments of Luca Kellermann

> I noticed I created this fork from `0.8.x` instead of `0.9.x`. But I'm seeing that `0.8.x.` has commits that `0.9.x` does't have. yeah, that's because some commits got cherrypicked...

or to make the history nicer, you can drop the commits before your work from the branch (e.g. with interactive rebase) and then rebase onto 0.9.x

It just seems to be in a non-standard location, see https://github.com/kordlib/kord/blob/0.9.x/buildSrc/src/main/kotlin/Documentation.kt#L25

JVM IR transformation doesn't seem to have this issue.

The usage is in context of [a Kotlin/JS library targetting nodejs](https://github.com/kordlib/kord). Is choosing one of CommonJS or ES modules instead of UMD going to impact Kotlin/JS applications using the library?...

> > I.e. will it force the chosen module system on them? > > Partially. You can force modular module system (CommonJS or ESM) via declarations - like we do....

Maybe I don't understand this right, but isn't delegation enough for your usecase? ```kotlin class YourGateway(private val delegate: Gateway) : Gateway by delegate { override val events: SharedFlow = TODO("use...

Ok, then I didn't understand this right. But just making `DefaultGateway` an `open` class also wouldn't solve this, the class wasn't designed for inheritance so there aren't any methods that...

I read the source and realized that this could happen. I then constructed this code. So it doesn't impact any real code of mine.

The link is correct again with 1.7.1: https://kotlinlang.org/api/kotlinx.coroutines/kotlinx-coroutines-core/kotlinx.coroutines/-i-o.html