Luca Kellermann

Results 133 comments of Luca Kellermann

> Is it a binary incompatible change to move functions to a parent class? no, it isn't

> and it is a change since the function signature changes, in this case there should be a deprecated version on the class, however that will make migrating kinda hard...

> Similar to `EmbedBuilder.Limits`, added one for `MessageBuilder`, altough this one is an interface, so I'm not sure if there are any side effects to this? No, that shouldn't be...

I'm curious, what do you use these values for? Hardcoding them into Kord might be an issue if Discord increases them at some point.

> Note: a major piece of terminology that's changed in this is that when a channel is closed with a cause, it's no longer called a "failed channel". The term...

> Semantically, `cancel` does not put the channel into a "cancelled" state, it only closes the channel with a `CancellationException` and consumes the elements, and it looks like every operation...

is there a reason this pr touches so many files?

> I think codegen kt doesn't run on jdk 8 the build failure looks more like a dependency resolution issue

> As Uuid really is a base building block of data models, the package dependencies really matter. For the JVM, instead of having uuid depend on nio, it should really...

The documentation (and implementation) for `compareAndSet` and `compareAndExchange` of `AtomicReference` and `compareAndSetAt` and `compareAndExchangeAt` of `AtomicArray` seems to be inconsistent across platforms. The documentation for [Common](https://github.com/JetBrains/kotlin/tree/master/libraries/stdlib/src/kotlin/concurrent) and [Native](https://github.com/JetBrains/kotlin/tree/master/kotlin-native/runtime/src/main/kotlin/kotlin/concurrent) says this:...