Luke Bakken
Luke Bakken
@henning-schild going forward, open a discussion here.
For what it's worth, I have forked this repo, applied this patch, and everything works as intended. Thanks @hexbloom!
@bollhals somehow this check started to work: ``` dotnet_diagnostic.RS0051.severity = error ``` I disabled it (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/Microsoft.CodeAnalysis.PublicApiAnalyzers.md#rs0051-add-internal-types-and-members-to-the-declared-api)
@bollhals @lechu445 - anything else? I plan to merge this by 0900PDT today.
@bollhals @lechu445 @paulomorgado thank you so much for your insights and contributions here 🥇
@ngbrown it appears to be converted - https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/main/projects/RabbitMQ.Client/Impl/RabbitMQActivitySource.cs
@ngbrown no worries at all! If you're testing out the v7 RC candidates, we would appreciate any feedback you have. Thanks!
It should be extremely easy to replace this with PowerShell. A pull request with an implementation would be welcome. Thanks!
Yes, it's safe to assume all users will have PowerShell at this time. Please do the following: * Create a new `rabbitmq-echopid.ps1` script that does all of the work. *...
I'll take some time to look into the code a bit. Off the top of my head, double-counting published messages seems slightly better than incrementing unrouteable messages.