Zhengbo Wang

Results 20 comments of Zhengbo Wang

Thanks, @MarcoGorelli, for your patience and selfless help. This PR wouldn't have been completed without you!

Hi @josef-pkt, could you find some time to review this PR? I'll make any necessary updates. Following this PR, I'll continue working on what we discussed in issue #9099.

Great work on `robust`! Do you mean we should address all the issues mentioned in #9099 and merge them at once? If so, I'll continue working on this and push...

Thanks for the explanation! I understand the importance of attention and time. Having a properly sized PR is indeed what we want.

Hello, @josef-pkt. I believe this pull request is ready for your review and will close the corresponding issue once approved. Please take a look and feel free to leave any...

Hi @lucasmouragomes, I was able to reproduce the example: ```python import pandas as pd df = pd.DataFrame({'val':[0, 1, 2]}) df.set_index(['a', 'b', 'c']) # KeyError: "None of ['a', 'b', 'c'] are...

Hi @mixmixmix, I was able to reproduce what you provided. However, from my personal view, why not just use a `dict` instead of a `Series`? As stated in the [documentation](https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.rename.html)...

> @luke396 I can look into this. If you want Of course, anyone can contribute to pandas. Replying 'take' will assign the issue to you.

> Not sure there's an advantage to adding extra code to make the validation happen earlier, especially if it doesn't quite match how the validation is done at the Rust...

Hi @MarcoGorelli, should we add some checks here https://github.com/pola-rs/polars/blob/2970c5706a5bbc39840ca5b0ffc9d4b3aab502cb/py-polars/polars/datatypes/classes.py#L461-L463 Similar to what's done here https://github.com/pola-rs/polars/blob/2970c5706a5bbc39840ca5b0ffc9d4b3aab502cb/py-polars/polars/_utils/convert.py#L163-L194 Or should we leave the error as it is? Do you have any thoughts on...