Luka Jeran comments

Results 143 comments of


                                            Luka Jeran

Content no longer fits the popup

Curious, does this not happen on Metamask and other extensions too?

Wrong computation of shares when undelegating (all) tokens

Also check if insufficient balance error is reported as `transaction: invalid nonce`

Emerald -> To Consensus: Offer wallet's Oasis account's addresses as a drop down

@Kc2fresh If you `Ethereum-compatible account > ParaTimes > Emerald > To consensus` and filled in Gate.io address, and your transaction succeeded, then Gate.io should have received tokens. But they might...

Refactor to not store password in memory

- How does metamask do this? - What is best practice for wallet extensions?

Support string path as HDKey.getAccountSigner param

Abandoned after no follow up in https://github.com/oasisprotocol/oasis-wallet-web/pull/990#discussion_r975440136

Can polling get stuck if an event id is skipped?

Update after https://github.com/oasislabs/oasis.js/pull/350: IDLE_TIMELAPSE was removed, so if an event id is skipped (Poll for id 1 and 3), it will definitely poll forever.

Toast Notification focuses original element after disappearing

Yes, in "Steps to reproduce" it restores focus to "Open Toast Notification". Which accessibility guidelines are you referring to? Modal Dialog? https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/#:~:text=When%20a%20dialog%20closes Alert? https://www.w3.org/WAI/ARIA/apg/patterns/alert/#:~:text=they%20do%20not%20affect%20keyboard%20focus

autoFocusingTags regex unintentionally matches `<data` and `<meta`

Update: this would match various web-components too

hdkey: save seed for use in multiple derivations

Quick attempt at profiling m/44'/474'/0' ... m/44'/474'/47': https://github.com/oasisprotocol/oasis-wallet-web/blob/8feb1357d44afc804f1a86b2a88c581152faf1a0/src/app/state/importaccounts/saga.ts#L70-L85 mnemonicToSeed: 841ms makeHDKey: 183ms derivePath: 519ms

Unable to withdraw to arbitrary consensus account

Related to https://github.com/oasisprotocol/oasis-wallet-ext/issues/243 Intentionally disabled in https://github.com/oasisprotocol/oasis-wallet-ext/pull/271