Results 143 comments of Luka Jeran

Some notes: - describe meaning in https://github.com/oasisprotocol/oasis-wallet-web/blob/59751cc/src/app/state/staking/types.ts#L7 - oasisscan has `active` field - oasismonitor doesn't. We could supplement it with RPC ```js const validators = nic.schedulerGetValidators(oasis.consensus.HEIGHT_LATEST) .then(a => a.sort((a,b) =>...

typed-redux-saga started including odd things in their npm package. I'll report upstream

We should only add a button for reclaiming 100% of stake for now. Transferring 100% and staking 100% will get complicated with fees

I temporarily deployed it to https://lukaw3d.github.io/oasis-wallet-web/ce527a5/#/

Minimal edge-cases to write tests for: - [x] lock while viewing an account causes error with clearTransaction (fixed in https://github.com/oasisprotocol/oasis-wallet-web/pull/975/commits/966b15cfbd6da72192098c21b8cb132d5abd34cd) - [x] quickly unlock + lock: caused error with network...

> @nikolaglumac > There is this minor thing I found: Once you create a profile, regardless of if you opened it later or not, "Close wallet" button is always visible...

@buberdds Thanks for finding those! - [x] 1. oh no :O (to reproduce: don't have a persisted profile. There's no bug for unlocked and skipped) - [x] 2. is probably...

Fixing 1. is annoying - I could refactor `resetRootState` to keep some slices, instead of resetting everything but: it doesn't feel correct to keep state after user clicks Close Wallet;...

Proof of concept https://github.com/oasisprotocol/wallet-poc/pull/1

Main issues with proof of concept - storing and syncing whole redux state: - it stores fatal error - syncing multiple tabs conflicts with cleanup, e.g. clearAccount open account in...