Łukasz Zimnoch

Results 9 comments of Łukasz Zimnoch
trafficstars

A thing to consider: Reusing symmetric keys generated using the ECDH algorithm upon key generation for securing signing P2P messages. It makes sense at the first sight though we need...

The code is ready for review. I'll undraft once https://github.com/keep-network/keep-core/pull/3209 and manual testing of this PR is done.

> - Run min number of clients Run 1 client, open new keep and request a signature ❌ Observed: ``` 16:12:22.585 ERROR keep-ecdsa: failed to generate threshold signer: [group should...

See also: https://github.com/keep-network/keep-core/pull/3427#discussion_r1053223872 https://github.com/keep-network/keep-core/commit/f341e4e0572f024397c6d1e8633fcca11dbccfad

Just flagging that this task is probably about implementing confirmations outside ethereum layer, see: - https://github.com/keep-network/optimistic-minting/pull/11#discussion_r1085369344 - https://github.com/keep-network/optimistic-minting/pull/11#discussion_r1086481509

> @lukasz-zimnoch, we don't need to worry about the failing `typescript-docs` workflow in this PR, right? This PR intentionally uses different contracts than on `main` and we don't intend to...

This is already supported by the library. You need to call `revealDeposit` with the `deposit` parameter having a non-zero `vault` identifier.

Some remarks: 1. Regarding vault names, Yearn has a naming convention. For Curve vault, the name should be: `Curve tBTCv2 Pool yVault` and for Saddle vault: `Saddle tBTCv2 Pool yVault`....

I made a closer look at the governance addresses we need to use and here are the conclusions: **Vaults** According to that [doc](https://github.com/yearn/yearn-devdocs/blob/master/docs/developers/v2/DEPLOYMENT.md#deploying-a-new-experimental-vault) we need to deploy the vault using...