Lukasz Stec comments

Results 26 comments of


                                            Lukasz Stec

Switch between distinct aggregation, mark distinct operator and OptimizeMixedDistinctAggregations automatically

> also allows for partial aggregation to be evaluated. I believe partial aggregation supports `MarkDistinct` too

Use "union" in partial aggregation output

closing as there is no interest in merging this

Switch between distinct aggregation, mark distinct operator and OptimizeMixedDistinctAggregations automatically

Yes, it's fixed by https://github.com/trinodb/trino/pull/15927

Use distinct aggregations by default (instead of MarkDistinctNode) for single distinct aggregation

the ``` Aggregation[FINAL](group)[aggr := count(aggr_partial), aggr_distinct := count(aggr_distinct_partial)] Exchange[group] Aggregation[PARTIAL](group)[aggr_partial := count(a), aggr_distinct_partial := count(distinct b)] Exchange[b] ``` rewrite looks like a potential good optimization and it's still not done...

SQL Error: Query failed: inputPositions is negative

> I think that this is an overflow when merging OperatorStats That is unlikely given the positions are kept in `long`.

SQL Error: Query failed: inputPositions is negative

> @lukasz-stec is inputPositions == 0 a valid value? Yes it is