Lukasz Stec

Results 26 comments of Lukasz Stec

Made it draft again as I'm gonna benchmark supporting more cases

Currently, our benchmarking infra is failing so the latest benchmark results will available next week probably. cc @sopel39 @gaurav8297

>Is BenchmarkBlockSerde#serializeLongDecimal or any other other JMH benchmark relevant here ? @raunaqmorarka I think `BenchmarkDecimalAggregation.benchmarkEvaluateIntermediate` is the best match for those changes although the first step and 50% of the...

the latest version tpch/tpcds benchmarks good improvement for tpch ![image](https://user-images.githubusercontent.com/8080198/185418030-743953ea-fd48-4d09-beb0-3d5678929728.png) [Benchmarks_decimal_aggr_serde_opt.pdf](https://github.com/trinodb/trino/files/9374630/Benchmarks_decimal_aggr_serde_opt.pdf)

`tpch/tpcds orc part 1k` on latest version (missing case implemented + using switch in deserailziation). Big gains for tpch, some for tpcds. ![image](https://user-images.githubusercontent.com/8080198/186607726-25dc4bdc-5e3f-4660-a267-65afa0b8ee43.png) [Benchmarks_decimal_aggr_serde_opt_orc_part_sf1k_250822.pdf](https://github.com/trinodb/trino/files/9422673/Benchmarks_decimal_aggr_serde_opt_orc_part_sf1k_250822.pdf)

I ran tpch/tpcds benchmarks for unpartitioned data + again for partitioned on the same code. For unpartitioned the gains are smaller + rle support does not help that much. orc...

Pushed the wrong branch, now should be fine

I ran tpch/tpcds benchmark on the current version (recently rebased on the master) + with `push_partial_aggregation_through_join=true`. The results are below. The improvement from this changes alone are smaller than before...

I ran tpch/tpcds sf1k orc part with this (paa union) on top of https://github.com/trinodb/trino/pull/13573 (decimnal serde optimization) and `push_partial_aggregation_through_join=true` It seems that this PR is still worth doing but it...