Lukas Oppermann
Lukas Oppermann
> 👋🏻 @lukasoppermann Regarding the failing checks: > > * I believe https://github.com/primer/octicons/actions/runs/6034055222/job/16371762629?pr=983 should be resolved when we run `yarn test -u` to make sure the snapshots are updated. We...
@eliperkins I think this worked. 🙏
@broccolinisoup so the issue with the npm test is: > @primer/octicons-react › should not update exports without a semver change [See here](https://github.com/primer/octicons/actions/runs/6271309563/job/17030758711) But the semver increase is done via changesets,...
Hey folks, what do we need to do to move this on and merge it? I don't want it to die. CC: @broccolinisoup @gavinmn @tallys
**Nevermind** I got it fixed by: 1. `cd lib/octicons_react` 2. `yarn` 3. `yarn build` 4. `yarn test -u` @broccolinisoup sadly I run into an error doing this: > yarn run...
Hey @camertron, I updated the `mark-github-24` icon, but the other one is 24 for me. Where do you see the size difference? Where is this screenshot from?
@camertron nice, I had fixed it before, as I don't use the export tool. It should be fine now hopefully, the code looks good to me. But the checks don't...
We are running into the same issue. We have base tokens for colors and those are referenced in semantic tokens. We don't want the base tokens to be used, so...
So @jorenbroekema this would still mean changing outputReferencea to accept a function or Boolean right?
> Just wanted to leave a quick round of comments after today! I feel like something worth investigating as next steps is if we can roll this out in the...