react
react copied to clipboard
IssueLabelToken with variants
This PR updates the IssueLabelToken
component to use variants
for color instead of hex colors.
Hex colors are still supported to provide backwards compatibility.
I added a new IssueLabelToken
component to the draft folder.
Changelog
New
Changed
Removed
Rollout strategy
- [ ] Patch release
- [ ] Minor release
- [ ] Major release; if selected, include a written rollout or migration plan
- [ ] None; if selected, include a brief description as to why
Testing & Reviewing
Merge checklist
- [ ] Added/updated tests
- [ ] Added/updated documentation
- [ ] Added/updated previews (Storybook)
- [ ] Changes are SSR compatible
- [ ] Tested in Chrome
- [ ] Tested in Firefox
- [ ] Tested in Safari
- [ ] Tested in Edge
- [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)
🦋 Changeset detected
Latest commit: 4d9b5ba6a4bbf2d1034873fed85ac90c2e89ccca
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
Name | Type |
---|---|
@primer/react | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
size-limit report 📦
Path | Size |
---|---|
packages/react/dist/browser.esm.js | 90.42 KB (+1.96% 🔺) |
packages/react/dist/browser.umd.js | 90.66 KB (+1.95% 🔺) |
Just wanted to leave a quick round of comments after today! I feel like something worth investigating as next steps is if we can roll this out in the existing component or not. Let me know if I can help out with that at all!
I'd love to get your help with this.
But one thing we need to keep in mind this PR changes two major things:
- Adds
variant
property (not breaking) - Change the color output for any given
fillColor
provided (this is at least visually very different)
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.