lukasniemeier-zalando

Results 16 comments of lukasniemeier-zalando

But can we support "zappr approvals" inside the native reviews? ![image](https://cloud.githubusercontent.com/assets/10497901/20299472/5f711106-ab1b-11e6-85da-a95e87debfec.png)

Maybe I am missing the point, but coming back to my comment https://github.com/zalando/zappr/issues/442#issuecomment-260586264 - isn't the "review" itself a "comment" (with a timestamp and all the bells)? So if I...

Curiously request bodies are send/flushed when calling `close` on the body stream, like it's proposed for the request compression plugin in https://github.com/zalando/riptide/blob/f2dde3c28a5a080471a125f3eca7b6d4693ae28f/riptide-compression/src/main/java/org/zalando/riptide/compression/RequestCompressionPlugin.java#L68-L71.

> The following was added in between 4.x and 5.x within the Netty4ClientHttpRequest and fixes the issue in Spring 4.x Which is funny, see https://github.com/zalando/riptide/pull/822#discussion_r346240552

Using the `NameSuffix` property solves my issue, thank you.

Yes filtering those would be helpful. Maybe just based on a special tag? I will look into that.

Using the changes in #183 one could define a multi-region web app template as shown in [2882d1d](https://github.com/lukasniemeier-zalando/senza/commit/2882d1d51b4f471cf59e2cfef5863b6ec17c8f41). ``` # create multi region web app definition files senza init hello-world.yaml #...

Also allows for use cases like #133 - after doing the `senza init` you are able to modify the `xxx-base.yaml`` (i.e. port configuration).

Out of the three default Spring OAuth2 `ResourceServerTokenServices`, only the `UserInfoTokenServices` [catches exceptions on the remote call](https://github.com/spring-projects/spring-security-oauth2-boot/blob/master/spring-security-oauth2-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/oauth2/resource/UserInfoTokenServices.java#L148-L153) and wraps them into an `InvalidTokenException`. I don't see anything specified about this...

@niallrox would you be able to provide a small Github repository that showcases the problem (i.e. your classes and configuration from above)?