Lukas

Results 24 comments of Lukas

> Please respond to comments I'm not quite sure what comments you are referring to :thinking:

I can't see any code comments :eyes: ![image](https://user-images.githubusercontent.com/32853499/158035477-4d3d5328-8522-4a4d-8edf-46744b139d50.png)

"Pending" is the culprit. You have to submit your review :wink: See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/approving-a-pull-request-with-required-reviews

I'm currently trying to use [Type Guards](https://www.typescriptlang.org/docs/handbook/advanced-types.html#user-defined-type-guards) to solve this issue: ```ts const isGeoJsonSource = (source?: Source): source is GeoJSONSource => source?.type === 'geojson'; const source = map.getSource('key'); if (isGeoJsonSource(source))...

While this was not explicitly resolved, the `Source` types are exported since [v2.1.2](https://github.com/maplibre/maplibre-gl-js/releases/tag/v2.1.2). That means you can now cast the return value like this: ```ts const source = map.getSource('geojson') as...

I just figured out which properties to set: ```yml alertmanager: alertmanagerSpec: podMetadata: annotations: annotation-1: test-value-123 ``` The same is possible for prometheus.

As a first version I would try to do something like the following. While there is definitely room for improving the design, I think this should be sufficient as a...

> Hmm, why show last week? I thought about it as "the results of last weeks competition". You might be right though, I like "current month" as well.

@tibbi I would like to have a go at this, but I saw #156 and am not sure whether you would accept such a contribution now? I think the structured...

@alextran1502 I saw that since #7679 the file extension for the archive download is only taken from `originalFileName`. Maybe a better fix than this one would be to set the...