Lukáš Hrázký

Hello, we don't primarily develop for that environment. Patches welcome though.

Yes! I don't want it there, after years of using FBReader (great app by the way :)). This should be dead simple to implement.

Hello, @ToruNiina, any feedback? I see the Windows CI has failed, unfortunately I am not able to test on Windows.

The goal of the PR is not to have a `FILE*`-based IO, the goal is to not have the `fstream` based one, because its error handling is very bad. In...

@ToruNiina would you please respond to my last comment? I find poor error handling a serious issue which is important for deciding whether to even use a library or not.

> I agree with you about we need to improve the error messages regarding file I/O. So, the problem here is about a `FILE*`. > > The policy of using...

> The reason why we use `std::vector` instead of `std::string` is that we don't need any of methods provided by `std::string`. We only need a container of `char`s, not a...

It appears the CI needs approval. I've made the change to have the `parse(FILE *)` variant. I've added a test for it (didn't like the copy-paste, but wasn't sure what...

Curious the CI has passed on Windows, even with the `fopen()` call still there... @ToruNiina what do you think about the new approach?

Another gentle ping. @ToruNiina please review if time at all allows, we kind of need reliable error handling...