Lukas Drescher
Lukas Drescher
I've added support for cell optimization with Arbor in 6aa15de. In the L5PC example, to determine a single location for the [extra-recordings in the bAP protocol](https://github.com/lukasgd/BluePyOpt/blob/arbor_integration/examples/l5pc/config/protocols.json#L11-L30), I've used the Arbor...
The commit c425101 allows using external catalogues in Arbor exports/optimizations (i.e. others than the [built-in ones](https://docs.arbor-sim.org/en/stable/concepts/mechanisms.html#built-in-catalogues)). This would enable to e.g. build the catalgoue at [examples/thalamocortical-cell/mechanisms](https://github.com/BlueBrain/BluePyOpt/tree/master/examples/thalamocortical-cell/mechanisms) by running [`arbor-build-catalogue tc...
Thanks for the review. To the first comment - thank you for your interest in the implementation of the JSON/ACC exporter. I think if you really want to understand the...
> For create_acc, we can add a some debug logging for the local variables you cite if you'd like, at the cost of a lot of noise > > >...
I've re-run the Arbor-Neuron validation of the L5PC model [here](https://github.com/lukasgd/BluePyOpt-utils/blob/master/validation/all-regions-22-oct/arbor_neuron_validation_analysis.ipynb) - the findings remain the same as above.
I've added some more docstrings to `create_acc.py` - please let me know if you have remaining questions.
I don't see why this would be a bug. I think the question is whether the loop is necessary or not. If you know the internals of `_arb_pop_global_properties`, you could...
Hi @anilbey, thanks for the additional tests and identifying corner cases. This pointed out where the test suite for the JSON/ACC exporter was lacking. I've added a test that checks...
Thanks for the review @anilbey. Please double-check the Arbor import mechanism at `bluepyopt/ephys/acc.py`. You may want to move it to `bluepyopt/ephys/__init__.py` or similar according to the previous discussion. Also, the...
Thanks for the feedback, @anilbey. The test suite is fixed now - the altered coordinates in the L5PC morphology with axon replacement instantiated with Neuron were introduced with a version...