Luiz Carlos Faria

Publish without basicproperties

2

BasicProperties is a fundamental mechanism to define behaviors of the message, like if the message is transient or durable. https://github.com/dotnetcore/EasyCaching/blob/bc4a0177cf2cc9c220afbee6aafc6065770af239/bus/EasyCaching.Bus.RabbitMQ/DefaultRabbitMQBus.cs#L94

This Async Implementation is fake

1

On source code https://github.com/dotnetcore/EasyCaching/blob/bc4a0177cf2cc9c220afbee6aafc6065770af239/bus/EasyCaching.Bus.RabbitMQ/DefaultRabbitMQBus.cs#L113 ExchangeDeclare is a blocking and painful operation, run entire publish as a task, sounds less fake .

Consumer is considering only EventingBasicConsumer ignoring AsyncEventingBasicConsumer

1

This consume implementation is considering only EventingBasicConsumer and ignoring async consumers, with AsyncEventingBasicConsumer. https://github.com/dotnetcore/EasyCaching/blob/bc4a0177cf2cc9c220afbee6aafc6065770af239/bus/EasyCaching.Bus.RabbitMQ/DefaultRabbitMQBus.cs#L158 it's affect this source too https://github.com/dotnetcore/EasyCaching/blob/bc4a0177cf2cc9c220afbee6aafc6065770af239/bus/EasyCaching.Bus.RabbitMQ/DefaultRabbitMQBus.cs#L58

Force every publish to execute ExchangeDeclare produce lacks of performance

1

When the code calls ExchangeDeclare, client send a command to server to ensure that exchange exists with these parameters. As a library do you don't know if the exchange must...

Opinative exchange type is a anti-pattern

1

Force type of exchange is a anti-pattern. The type of a exchange is the unique responsibility of developer, never a generic publish can be opinative around this. https://github.com/dotnetcore/EasyCaching/blob/bc4a0177cf2cc9c220afbee6aafc6065770af239/bus/EasyCaching.Bus.RabbitMQ/DefaultRabbitMQBus.cs#L93

ConnectionFactory has many options specific of runtime environment. Assuming the you must perform the construction of this classes take for yourself a lot responsability to cover many cases. Use dependency...

* Improving testability with IMinioClient interface * Adding all non deprecated operations to IMinioClient * Removing factory (With*()) operations from interface keeping on MinioClient class.

.NET 3.1 causes crash because lost support and was deleted in some environments. Moving .NET projects to .NET 6 (latest LTS)

New warning found: ```npm WARN deprecated [email protected]: Typings is deprecated in favor of NPM @types -- see README for more information```