kde-material-you-colors icon indicating copy to clipboard operation
kde-material-you-colors copied to clipboard

Folder icons not looking right

Open Prayag2 opened this issue 2 years ago • 8 comments

Folder icons in Dolphin don't look quite right. Here are some screenshots:

On dark themes image

On light themes image

The colour of the emblems should be dark when the folder colour is light and light when the folder colour is dark.

Prayag2 avatar Apr 08 '22 08:04 Prayag2

Have you tried using the new option to switch between icon themes? It was added in the latest version. Can you also share how does it look with the default breeze dark and light themes? Never noticed this because I always use Papirus icons, and checking right now it seems like my dolphin is a bit buggy as selecting makes the folders all white.

luisbocanegra avatar Apr 08 '22 08:04 luisbocanegra

Default Breeze Dark: image

Default Breeze Light: image

ohh it's working fine with kde-material-you-colors --iconslight ICONSLIGHT image

but the colour of the small icons in the sidebar look weird :/

Prayag2 avatar Apr 08 '22 08:04 Prayag2

Thanks.

ohh it's working fine with kde-material-you-colors --iconslight ICONSLIGHT

Are you running it exactly like that? Probably not but just to be sure, you have to pass after --iconslight the name of one of the installed icon themes.

luisbocanegra avatar Apr 08 '22 08:04 luisbocanegra

Yes, I'm running it exactly like that lol

Prayag2 avatar Apr 08 '22 09:04 Prayag2

I made a mistake!! I was using a custom accent colour that's why it was working :( When using the accent colour of the colour scheme, it's still not working: image

Prayag2 avatar Apr 08 '22 09:04 Prayag2

Okay, I will check this later, thanks for reporting it.

luisbocanegra avatar Apr 08 '22 09:04 luisbocanegra

Update, tried reducing the tint of folders background with

[Colors:Selection]
BackgroundNormal=

until icons were readable, but didn't like the result as it also affected other elements that looked right otherwise :-1:

For the folder icons, Breeze uses window text color, which is almost black (light theme) or white (dark theme)

[Colors:Window]
ForegroundNormal=

image

I think this is more of a conflict with the default colors for the breeze icon theme, I don't know why they didn't use

[Colors:Selection]
ForegroundNormal=

image

Maybe there are other parts of the ui that depend on the same colors and causes readability issues somewhere, so I don't think I can solve this one without sacrificing consistency. Or changing all the icons afected by this manually Maybe it would be worth asking the KDE VDG group what do they think about this but idk.

Please leave this open for now.

luisbocanegra avatar Apr 10 '22 17:04 luisbocanegra

Just an update on this issue, I use the Papirus-Colors icons, they follow the current color scheme and had this same issue.

I patched those icons replacing the css class in some elements and it seems to have worked perfectly.

If someone also uses the Papirus icon theme you can get the patched version if Papirus-Colors from my fork

Install both Papirus icon theme and Papirus-Colors and apply Papirus-Colors in system settings

Probably the same could be achieved patching Breeze icons too image

luisbocanegra avatar Aug 25 '22 00:08 luisbocanegra