Zihua Li

Results 343 comments of Zihua Li

I thought it before. Could you give me the link of the fork?

Hi! I modified your code to invoke `gc()` before measuring memory usage, and the "leak" is fixed. I think it's just because V8's garbage collection didn't kick in. It's possible...

What if including `article.title` in the ``? So the html would be `'' + article.title + '' + article.content + ''`;

Makes sense. We can add a `h1` tag with the content of `article.title` when the `article.content` doesn't contain a `h1`.

The result seems correct for me. The code: ``` javascript read('http://www.inc.com/gene-marks/the-one-way-to-tell-if-you-re-a-successful-entrepreneur.html?cid=sf01001', function(err, article, meta) { console.log(article.content); }); ``` And output: ``` html I'm not a very successful entrepreneur.  Are you?......

Exactly. Just wonder whether it should be a built-in style though it's trivial to implement it.

Sorry if this is off-topic, ioredis has just released [v5.0.0](https://github.com/luin/ioredis/releases/tag/v5.0.0). I think it would be nice if this update could be added to v5 😄.

当初考虑过多个时区的问题,不过后来懒了一下。下版本加个配置选项吧

Implemented it in ioredis (a Node.js redis client): https://github.com/luin/ioredis#reconnect-on-error. Hope that helps.

Hi @ajinabraham, thank your for bring this issue up! Since we're using `eval()` internally, the security issues are impossible to be avoided. Even if we replace `eval` to `new Function`,...