Zihua Li comments

Results 343 comments of


                                            Zihua Li

A rest element must be last in a tuple type.

I think the root cause is TypeScript < 4. Can you create a new project with TypeScript 4 installed? I think there could be multiple TypeScript versions in your projects.

With commandTimeout option set, active timers are not cleared on client disconnection

We can't clear the timeout on rejections because a rejection doesn't necessarily mean a command is failed, instead, the connection can be reconnected and the command can be resent so...

With commandTimeout option set, active timers are not cleared on client disconnection

Yeah I think we can probably clear the timeouts on "flushCommandQueue" which will be called on the "end" event.

Redis connection isn't retrying if it fails on initial connection

Hey @avigoldman 👋 I tried this but it actually works for me. When the server is not started and I call createRedis, it shows "is reconnecting" and once I launch...

Error: All keys in the pipeline should belong to the same slots allocation group

Hey @arthosofteq 👋, > These 2 keys should be allocated to the same shard. The 2 keys belong to two different slots, although the two slots may be severed by...

[WARN] This Redis server's `default` user does not require a password, but a password was supplied

According to the logs, I think the cause is a password is provided to the server whereas the default user doesn't have a password set. Does removing the password part...

[WARN] This Redis server's `default` user does not require a password, but a password was supplied

Hey @lukats 👋 , Thanks for the follow-up! However, I still don't get it. The warning `[WARN] This Redis server's `default` user does...` is printed whenever ioredis receives replies from...

Handle "LOADING Redis is loading the dataset in memory"

ioredis already supports detecting loading in standalong version: https://github.com/luin/ioredis/blob/master/lib/redis.js#L420-L428. Seems we just need to wait for the "ready" event of the new redis node here: status.https://github.com/luin/ioredis/blob/master/lib/cluster/connection_pool.js#L58-L63

Handle "LOADING Redis is loading the dataset in memory"

Hmm...I just checked the code, and it seems that when a node has not finished loading data from the disk, the commands sent to it will be added to its...

Handle "LOADING Redis is loading the dataset in memory"

That's strange. Either the node is a slave or a master doesn't affect the support of offline queue. Are you able to reproduce the issue? Or enable the debug log...