Ludovic Henry
Ludovic Henry
Hi @blapie, what could we do to get this PR (and associated ones https://github.com/shibatch/sleef/pull/521 https://github.com/shibatch/sleef/pull/522) to go forward?
It's not going to be that trivial as there are conflicting types between SP and DP modes. For example, the following: ``` #ifdef ENABLE_RVV_SP // Types that conflict with ENABLE_RVV_DP...
Yes, it's all working now
@blapie also rebased this one now that https://github.com/shibatch/sleef/pull/520, https://github.com/shibatch/sleef/pull/521, and https://github.com/shibatch/sleef/pull/503 have been merged
For GitHub actions, we only do Release builds, thus we hit the error. I would guess that LLVM doesn't generate the problematic instruction when in Debug mode.
> Have you checked all the call sites to see if this is OK? I believe we even have a test (DirectoryCreationTest.CreateDirectoriesAndUniqueFilename) that should break here: I've checked that all...
> Sorry, I'm still confused. I haven't had a chance to test your code, so I may be missing something, but how is this line not failing with your change?...
The licensing [[1]](https://github.com/shibatch/sleef/blob/master/LICENSE.txt) seems to allow us [[2]](https://www.tldrlegal.com/license/boost-software-license-1-0-explained) to copy/paste the source code into the JDK. We would only need to include the copyright and license, which are both no-brainers.
@GoeLin What would be the next steps after creating [the CSR](https://bugs.openjdk.org/browse/JDK-8324306)? I'm sorry it's a process that's very new to me. Thanks for your help!