Ludovic Henry

Results 57 comments of Ludovic Henry
trafficstars

@Orvid anything else you would like me to get done? Thanks

cc @assignUser @Yuhta @pedroerp @kgpai It's building on all pull requests. The testing would happen on a subset of PR or on nightly as discussed previously, and would be done...

@assignUser ok, sounds good, I'll fold it into the adapters build.

@assignUser the build isn't much smaller as Wave depends (directly or indirectly) on most of the other velox libraries. Also, it doesn't add much to the existing build in terms...

> > If you're concerned about resource/machine usage, we can build a limited set of cuda versions (what's the one(s) you'd like to focus on?) and build the larger set...

> @luhenry looks good but could you change the test skipping code so it doesn't cause gtest to pick up a [failed test](https://github.com/facebookincubator/velox/actions/runs/8627576322/job/23662809679?pr=9335#step:11:684)? Otherwise this will always fail the adapters...

@assignUser I've just merged the `main` branch as it's failing with https://github.com/facebookincubator/velox/actions/runs/8643569195

> @luhenry yeah the fix is in #9451 feel free to apply it to this PR, I hope it get's merged soon^^ Done.

@assignUser all tests are now passing.