Ludvig Gunne Lindström
Ludvig Gunne Lindström
I realize know that this doesn't actually solve the main in example in #10305 (only the simpler one in the comments), since it relies on the name of the struct...
> That makes me think of some potential issues. What happens if the project changes and files are no longer contained? That previous output is probably not removed - is...
> The note about `__cplusplus` is also interesting. And it also has `_MSVC_LANG` as equivalent. Stupid quirks... The `__cplusplus` thing is quirky indeed... atleast with this change the correct substring...
> I have similar code which deals with the language. I guess the basic logic can be re-used/combined from the changes. Hm, I'm not sure what you mean, do you...
> FYI when we need to test something related to inputs there is three different cases to consider: Okay, thanks! I'll be focusing on other tickets for a while so...
I noticed the percentage reported in `SingleExecutor` for `FileSettings` is based on the number of files instead of the file sizes, is this intentional? https://github.com/danmar/cppcheck/blob/85eadd8572a05c320ab972668fc2765edd6447be/cli/singleexecutor.cpp#L67
> I think we should just consider the amount of files. That makes sense. I'm not sure how the workflow would look for that, should it be it's own ticket?
> I don't have super strong opinion.. but generally.. based on number of files the guess will be off more imho. A small file would generally go faster to analyse...
I guess we actually have both right now, with `1/3 files checked 42%`.
A different PR for this ticket has been merged.