Ludovico Fischer
Ludovico Fischer
> Hey @ludofischer Is this package still used in cssnano? No, it's not being used any more there. I can still improve the type declaration if you're interested.
> @vankop oh, it means cssnano (built-in minifier) remove them as comment > > /cc @ludofischer How can cssnano know that the banner plugin added the comment? If it looks...
For context, this is the discussion for the PostCSS change https://github.com/postcss/postcss/issues/1703
In 8.2, it still fails to parse, but at least does not crash.
Moving the `UNKNOWN_DIMENSION` before `NUMBER` in the lexer solves this issue, but then it prevents numbers with exponents to be reduced.
@alexander-akait Do you mean `max(100px, 200px) -> 200px`. That would be an additional feature, right? I don't think it solves the current bug.
Still throws a warning even though it does not crash in 8.2
Strangely I cannot reproduce this using only postcss-cli.
> Any updates? Since https://github.com/postcss/postcss-calc/pull/137 it should just warn instead of crashing. Does is still crash for you? The underlying problem is that the parser is incomplete, but to fix...
> In case this helps anyone, calc(var(--base-padding) * -1) throws an error whereas calc(-1 * var(--base-padding)) does not. But does it just print an error message or does it crash?