ludamad
ludamad
Post-earthly cleanup
was refactored by Charlie a while back
``` [ RUN ] reference_string.mem_grumpkin_file_consistency ==2999==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5591ed5f504b in bb::group_elements::affine_element::is_point_at_infinity() const /usr/src/barretenberg/cpp/src/barretenberg/srs/factories/../../ecc/curves/bn254/../../groups/./affine_element_impl.hpp:120:9 #1 0x5591ed5ec34d in bb::group_elements::affine_element::operator==(bb::group_elements::affine_element const&) const /usr/src/barretenberg/cpp/src/barretenberg/srs/factories/../../ecc/curves/bn254/../../groups/./affine_element_impl.hpp:140:29 #2 0x5591ed5eaff2 in testing::AssertionResult testing::internal::CmpHelperEQ(char const*, char const*, bb::group_elements::affine_element...
``` [ RUN ] ClientIVCTests.Full ==1310==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5558408d81a7 in unsigned int bb::scalar_multiplication::construct_addition_chains(bb::scalar_multiplication::affine_product_runtime_state&, bool) /usr/src/barretenberg/cpp/src/barretenberg/ecc/scalar_multiplication/scalar_multiplication.cpp:609:21 #1 0x555840a4ae9c in bb::curve::BN254::AffineElement* bb::scalar_multiplication::reduce_buckets(bb::scalar_multiplication::affine_product_runtime_state&, bool, bool) /usr/src/barretenberg/cpp/src/barretenberg/ecc/scalar_multiplication/scalar_multiplication.cpp:476:36 #2 0x555840c15a46 in bb::curve::BN254::Element bb::scalar_multiplication::evaluate_pippenger_rounds(bb::scalar_multiplication::pippenger_runtime_state&, bb::curve::BN254::AffineElement*,...
``` [----------] 2 tests from ECCVMComposerTests/0, where TypeParam = bb::ECCVMFlavor [ RUN ] ECCVMComposerTests/0.BaseCase ==1836==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x55778e500b1a in bb::field::montgomery_mul(bb::field const&) const /usr/src/barretenberg/cpp/src/barretenberg/ecc/curves/bn254/../../fields/./field_impl_generic.hpp:467:12 #1 0x55778e500b1a in bb::field::operator*(bb::field const&) const...
This caused compiler warnings and overall it's dubious that we would really save much by packing stuff into a single `fr` versus just directly returning the data we want (a...
Currently we don't have all the parts to fully integrate into bb, and are not ready for downstream users (i.e. Noir) to switch over. We should eventually replace the proveAndVerify...
After namespace simplification, a bunch of using statements can be cleaned up. They are tagged with this issue.
This relied on tcmalloc being globally available, which it no longer is as it was causing issues with general compilation apparently. Those should be identified, or a local tcmalloc solution...
We now have bn254 and grumpkin, and they come from internet sources. We don't check the SRS is on curve at all, adding to a checklist of stuff if a...