Lei Shi

Results 10 comments of Lei Shi

> I'm -1 on this for two main reasons: > > 1. It's limited to a single, new SIMD instruction that isn't widespread yet > 2. I'm not convinced that...

> > Bit swap is useful in endian conversion > > Right, but I don't see that as a common operation that would be a bottleneck in node applications. Is...

> > Offhand if I had to pick a specific feature that would be worth optimizing yet it would be supporting accelerated base64 encoding with the base64url alphabet or base64...

> I have similar concerns. Adding new things to `deps` is a tough decision, and I don't expect `swapX()` to be used much, especially since these do not exist on...

> > Research common/popular use cases for node, break down the potential bottlenecks [..] and see if any of them can be improved by changing the relevant parts in node...

Changing this patch after tasking all the considerations from review comments: 1. Patch is too big that add a deps folder -> I made all the code changes into the...

> The auto-suggest feature looks a bit weird right now, is this expected? > > I think the suggested content should require confirmation before use. For example, if I input...

Please checkout this slides for the Ghost.js workload design and opt results. [QAT-HW-Ghost-Opt.pptx](https://github.com/OpenVisualCloud/Dockerfiles/files/12594783/QAT-HW-Ghost-Opt.pptx)

> The check for OS support has not been updated & still only checks for AVX support. AVX512 added masks, 512-bit register size & 16 new registers. There are 3...

> A failure can be reproduced by booting linux on a machine with AVX-512 disabled explicitly. > > I have reproduced this on an AMD Ryzen Threadripper PRO 7975WX. For...