luckysmg

Results 61 comments of luckysmg

And If you want to run locally to test the benefit. You can use this demo code😄 **It can be run directly without any setup:** [flutter_demo.zip](https://github.com/flutter/engine/files/9265362/flutter_demo.zip) You can test according...

Hi @gaaclarke @cyanglaz I have merged `main` into this branch, so that maybe it will not take so much time to compile code when you switching to this branch and...

Hi @gaaclarke @cyanglaz Sorry.I think I didn't made things very clear before. Here is coming: **This PR is to mainly avoid the keyboard animation junk and laggy on Promotion devices...

@rotorgames Oh yeah, I'll also take a look that problem you said.

Here is the corresponding flutter framework ref to run locally: ab23233fa8212b2813d92191e520d3cc88ffd362

Maybe just delete the code below can fix this? ```objective-c // Delete this code in keyboardWillBeHidden id isLocal = info[UIKeyboardIsLocalUserInfoKey]; if (isLocal && ![isLocal boolValue]) { return; } ```

Updated: `keyboardWillChangeFrame` will include `show/hide/changeFrame` so maybe `keyboardHidden` seems to be redundant. So this look seems better, and we just need to make sure that the `bool isDismissing = CGRectEqualToRect(keyboardFrame,...

I think this is ready for review ^_^

I just added `GPUTracerMTL` for metal backend. And if it is necessary, later I will add corresponding `GPUTracer` for other backends after this PR is landed. (`GPUTracerVK` and `GPUTracerGLES`, they...

> As from video above, keyboard and textfield move up almost in sync. While in flutter they are not in sync and visual result looks weird to the end user...