engine icon indicating copy to clipboard operation
engine copied to clipboard

[Impeller] Add interface for metal frame capture.

Open luckysmg opened this issue 2 years ago • 3 comments

List which issues are fixed by this PR. You must list at least one issue. https://github.com/flutter/flutter/issues/111421

We can add this in info.plist in our test app to get gputrace file if we save it locally.

<key>UIFileSharingEnabled</key>
<true/>
<key>LSSupportsOpeningDocumentsInPlace</key>
<true/>

Preview

https://user-images.githubusercontent.com/49340347/193020738-f89de8b8-5fa2-4bd3-b2a8-80ef05c566be.mp4

Pre-launch Checklist

  • [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I signed the [CLA].
  • [x] All existing and new tests are passing.

luckysmg avatar Sep 29 '22 11:09 luckysmg

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Sep 29 '22 11:09 flutter-dashboard[bot]

Gold has detected about 2 new digest(s) on patchset 13. View them at https://flutter-engine-gold.skia.org/cl/github/36499

skia-gold avatar Oct 08 '22 07:10 skia-gold

I think this is ready for review ^_^

luckysmg avatar Oct 11 '22 05:10 luckysmg

I just added GPUTracerMTL for metal backend. And if it is necessary, later I will add corresponding GPUTracer for other backends after this PR is landed. (GPUTracerVK and GPUTracerGLES, they will be with default implementation) ^_^.

luckysmg avatar Oct 19 '22 03:10 luckysmg