lucioperca

Results 8 comments of lucioperca

If there's anything confusing about the steps to reproduce this bug or an objection to the format of the pull request, I'd be happy to try and address them.

Same issue is fixed by: https://github.com/signavio/react-mentions/pull/661

I can confirm that this issue was fixed by: https://github.com/signavio/react-mentions/pull/661 Closing this issue and the original PR from 2020 fixing it.

I was able to resolve a similar error by forcing react-trello to use a pre-v6 version of styled-components. Basically, throwing this into package.json: ``` "resolutions": { "react-trello/**/styled-components": "5.3.11" } ```...

@bostrom I checked the tests in the PR. It looks like the ```whenGET``` cases in the new tests for ```setPlainByDefault``` may be using the responses designed in the top level...

This seems to happen because ```parseResponse``` populates the ETag data, which is called before the ```config.plainByDefault``` check, whereas the rest of the restangularized methods are set in ```restangularizeElem``` / ```restangularizeCollection```,...

Took a stab at fixing this (as well as fixing one of my modified unit tests). See updated: https://github.com/mgonto/restangular/pull/1457

@bostrom I agree with that idea in principle, but I'm not sure how best to go about it. It looks like ```restangularizeElem``` and ```restangularizeCollection``` look like they don't receive any...