Bobby
Bobby
Thanks for the update @JeffBeltran
> I would expect `faker.date.birthday` to have a bit different signature: > > ```js > faker.date.birthday(age: number, refDate?: string | Date) > faker.date.birthday(options: { min: number, max: number }, refDate?:...
I removed the older js files
I didn't notice the example files were removed from the newer structure of the repo. I removed them from this PR too.
Everything that was suggested is added. Please check
> General comment: you should separate zodiac signs and birthday into two separate PR, as they are totally independent. @pkuczynski Maybe from next time, I will target smaller issues/PRs. Too...
I see. Although, I still fail to see the usage of 2 PRs now since this once is almost completed review and is targeted for v6.2 and won't be merged...
Okay, done. I used: ```js return new Date( this.faker.datatype.number({ min: startDate, max: endDate, }) ); ```
I have resolved all the notified issues, and added comments to the unresolved ones.
Tests pass on my system but are failing here. I am looking into it. Please disregard the review request.