Prashant Shubham

Results 329 comments of Prashant Shubham

@nihcas700 you can fork the repo and raise a PR, no other permissions are required I believe.

@arpitbbhayani I believe this can be closed, since similar related issue PR is merged now https://github.com/DiceDB/dice/pull/288

@arpitbbhayani can I pick this up?

@Vsareen0 would like to pick this up, if you're not working on this actively. cc: @JyotinderSingh @AshwinKul28

> @lucifercr07 , yes, I've made all the changes in the PR which were suggested previously, but I haven't made [this](https://github.com/DiceDB/dice/pull/289#discussion_r1711336941) change, because the tests were failing if I remove...

> Sure @lucifercr07 , here is the error on removing the `else` blocks: We need to remove the `else` block but not the code inside it. ``` if XXoption {...

@soumya-codes would like to discuss once regarding the changes for Standardization of errors [issue](https://github.com/DiceDB/dice/issues/248) Wanted to check on few points: 1. Should we follow a `enum` like structure to standardise...

@soumya-codes @JyotinderSingh please review once

@JyotinderSingh Have pushed the fix on my fork branch, was this PR accidentally closed? Shall I raise a new PR?

@JyotinderSingh build passed, please merge.