dice icon indicating copy to clipboard operation
dice copied to clipboard
verified publisher icon DiceDB

Tests for command `SET`

Open arpitbbhayani opened this issue 3 years ago • 8 comments

Currently, there are almost no unit tests for the SET command. We need a comprehensive test suite for this command that also checks the correctness and completeness.

  1. covers the correctness of single command
  2. covers the correctness when multiple commands are fired
  3. no commands are dropped abruptly
  4. ensure we check for small, large, and massive inputs (if applicable)

arpitbbhayani avatar Oct 31 '22 14:10 arpitbbhayani

@arpitbbhayani for SET command the tests are in set_test.go. Are more tests required for it?

sahil1913 avatar Nov 01 '22 13:11 sahil1913

Yes. Correctness is yet to be tested. Long input, different data types, and bulk commands.

arpitbbhayani avatar Nov 01 '22 13:11 arpitbbhayani

@arpitbbhayani I have made some code changes for this task, would be great to have the permissions to open a PR.

nihcas700 avatar Jul 31 '24 23:07 nihcas700

@nihcas700 you can fork the repo and raise a PR, no other permissions are required I believe.

lucifercr07 avatar Aug 23 '24 04:08 lucifercr07

Thanks @lucifercr07. Opened the MR. Looks like there are some conflicts, let me rebase it

nihcas700 avatar Aug 23 '24 05:08 nihcas700

@JyotinderSingh - I can pick this up, if it's available.

psrvere avatar Sep 25 '24 04:09 psrvere

@JyotinderSingh - I can pick this up, if it's available.

I believe we already have comprehensive tests for the SET command now. Could you check if there are any cases we are missing?

JyotinderSingh avatar Sep 25 '24 05:09 JyotinderSingh

Sure I will check and get back.

psrvere avatar Sep 25 '24 07:09 psrvere

@JyotinderSingh - Reviewed all unit and integration tests for SET command. Found a few gaps and raised PR for the same - #1118

psrvere avatar Oct 17 '24 07:10 psrvere