lucas_nz

> Thank you for your work on this! It would be great if there was a fourth option to check both IPv4 and IPv6, avoiding the need to create 2...

Updating yourself is relatively straight forward: 1. Download the signal installer from signal.org 2. Don't run the installer, use something like 7zip to extract the contents. 3. Locate the file...

> Could you add Resolves #ISSUE-NUMBER to the issues this PR resolves? I've already listed this in the description: This addresses (at least in part) the following issues: https://github.com/louislam/uptime-kuma/issues/3542 https://github.com/louislam/uptime-kuma/issues/1242...

> Could you add Resolves #ISSUE-NUMBER to the issues this PR resolves? As I described in the description, this PR supports ping, tcp, and dns. Which means it resolves the...

> #3542 and #1025 can be considered fixed since they specifically mention the Ping and TCP Port monitor types. Yes, I agree it Resolves #1025 Without digging into #3542 it's...

Thanks for the comments. I'm happy to make adjustments. I have a few questions. > * We don't provide new features for 1.23.X. You have to rebase to `master` branch....

> Maybe we should rename the variable to `ipByHostname` or similar to prevent confusion, since it's definitely not a hostname anymore. Happy to change the variable name. It stays as...

> Ah I see how it works now, I'm okay with this. > > I'm also slightly concerned that you're setting the value to null on error. Would continuing to...

@chakflying updated to throw instead of setting to null. This is definitely an improvement. Thanks.

> Could you add `Resolves #1242` to the description? This way it will be closed if merged @CommanderStorm see more earlier comment below: > As I described in the description,...