magic-link icon indicating copy to clipboard operation
magic-link copied to clipboard

Adding a proper README

Open lucasmontano opened this issue 4 years ago • 12 comments

Adding commits guideline, fastAPI introduction and project overview to the README.

lucasmontano avatar May 08 '20 16:05 lucasmontano

Does its issue has been complete?

jbarbosaamancio avatar May 10 '20 14:05 jbarbosaamancio

Screenshot from 2020-05-11 13-41-13

@lucasmontano fastapi supports async functions, watch out ^

ArthurFleischman avatar May 11 '20 16:05 ArthurFleischman

its on their doc

ArthurFleischman avatar May 11 '20 16:05 ArthurFleischman

Screen Shot 2020-05-11 at 18 51 01

lucasmontano avatar May 11 '20 16:05 lucasmontano

one more thing to update on readme.... thanks lucas hahaha

ArthurFleischman avatar May 11 '20 16:05 ArthurFleischman

Does its issue has been complete?

@jbarbosaamancio nops, i already sent a pull request, but i was for flask content, now i updated it, and im waiting response...

ArthurFleischman avatar May 11 '20 16:05 ArthurFleischman

@ArthurFleischman I sent pull request to readme only, after do you may see my pull request about readme? I'm seeing some things about fast API it's amazing and easy is much similar to flask

jbarbosaamancio avatar May 11 '20 18:05 jbarbosaamancio

@jbarbosaamancio its good, but now, you already have stuff to put in, not just the headers

ArthurFleischman avatar May 11 '20 22:05 ArthurFleischman

go to my feature-README and read my README.md. @lucasmontano didnt like just the main.py and README in the SAME pull request

ArthurFleischman avatar May 11 '20 22:05 ArthurFleischman

@ArthurFleischman I checked your PR, but you're changing multiples files. ReadME PR should change only the ReadME file. All PRs need to be concise and address only what's needed to resolve an issue.

lucasmontano avatar May 12 '20 10:05 lucasmontano

ok! bad habit...

ArthurFleischman avatar May 12 '20 14:05 ArthurFleischman

of mine

ArthurFleischman avatar May 12 '20 14:05 ArthurFleischman