Lucas Gomide

None exception is raised when the point coordinates are invalid

7

Hi, everyone! Why there is a rescue exception when a request to generate a point fails? Should we raise an exception If the provided coordinates are not valid? https://github.com/rgeo/rgeo-geojson/blob/7316c9642c601c9d8f8070acd4ef62452a7eb029/lib/rgeo/geo_json/coder.rb#L198

documentation

1

Add comments for exported functions

lint suggested ``` lucasgomide/snitch/tsuru/api.go:13:6: type name will be used as tsuru.TsuruAPI by other packages, and that stutters; consider calling this API lucasgomide/snitch/tsuru/api.go:13: warning: exported type TsuruAPI should have comment or...

This function save into struct the config parsed, in order to semantic reasons `ReadConfigFile` doesn't sound good to me

lint suggested ``` lucasgomide/snitch/hook/newrelic.go:16:2: struct field ApplicationId should be ApplicationID lucasgomide/snitch/hook/newrelic.go:17:2: struct field ApiKey should be APIKey lucasgomide/snitch/hook/slack.go:14:2: struct field WebhookUrl should be WebhookURL lucasgomide/snitch/hook/slack_test.go:9:5: var webhookUrl should be webhookURL...

Some requests to Tsuru API exceeded Client.Timeout, then has been logged message on prompt. ``` Snitch: Get http://xx.x.x.x:8080/deploys?app=xxxxx&limit=1: net/http: request canceled (Client.Timeout exceeded while awaiting headers ```

chore: add type hint to client_class

1

It's very useful for IDE suggestion method