Lucas Amoroso
Lucas Amoroso
@ivantopo,@SimunKaracic Thanks for the review! I'll be doing some testing with [Armeria examples](https://github.com/line/armeria-examples), for now i've no problems with the **Operation Name** refactor but i need to take a closer...
Hi! In the last couple of days, with @dpsoft help, we've been changing the current implementation. I've been doing this in another repo because is simple to me to do...
Hi! I pushed a reimplementation of this module, i think is a better approach. I've been doing manual testing with [armeria-examples](https://github.com/lucasamoroso/kamon-armeria-test/tree/master/src/main/java/example) no big issue found. In the next couple of...
> 1. You are storing the context in 4 different places, but never closing the returning scope. Won't that leave dirty threads around? The contexts are stored inside a try-with-resources,...
Hello!! I think this pr is ready, I have been making a lot of changes in the last time because the first approach I gave to the instrumentation did not...
Hi @ivantopo! Sure I'll be working on this
Hey @ivantopo! I did a rebase and fixed the tests. The problem with the tests was that they must extend from `InitAndStopKamonAfterAll` to start and stop Kamon.
Hi @ivantopo ! I've tried with all java versions but the problem was with the attach mode. [This](https://github.com/kamon-io/Kamon/pull/854/commits/edcb49d09b1d147af99f04aa9e496f98ee8b3d18) commit should fix that issue. I'll stay tuned for comments 😄
> So what is the status of armeria module ? Hi @yarosman! I've resolved all @ivantopo's comments and I'm waiting for more comments or maybe this can be merged. Are...
> And I see there is [v1.15.0](https://armeria.dev/release-notes/1.15.0) available I've updated armeria dependency and rebase with the upstream