LucasZF

Results 128 comments of LucasZF

We need to replace the logic that holds the spans references from here https://github.com/getsentry/sentry-dotnet/blob/12c46e1b8a56211075cab11a9b32acc932ef7f35/src/Sentry.DiagnosticSource/Internals/DiagnosticSource/SentryEFCoreListener.cs#L43-L45 One approach that could be followed is to do something similar to what was done on...

> @lucas-zimerman - Any update on this one? The warning noise was reduced on #1368. As pointed on this comment https://github.com/getsentry/sentry-dotnet/issues/1350#issuecomment-996915765 the current code doesn't work correctly with multiple connections/queries...

@mattjohnsonpint @SimonCropp EDIT 2: I could not repro it, but I'll keep investigating it EDIT 3: It may be related to users calling an endpoint with the wrong Method (GET...

Ok so the issue seems related to how the Request is being received: ``` curl \ -X OPTIONS \ --compressed \ -H "Accept: */*" \ -H "Accept-Encoding: gzip" \ -H...

@SimonCropp sorry for the confusion, after further investigation on this issue, it seems related to this: https://github.com/axios/axios/issues/475#issuecomment-253212139 Basically the client sends two requests one with the Method `OPTIONS` to see...

![image](https://user-images.githubusercontent.com/8229322/185655368-db9a8c42-5a7f-45fc-b5d4-5d1fe6371c71.png) ![image](https://user-images.githubusercontent.com/8229322/185654287-b8598e25-608b-4b2e-a618-80e02f560bc5.png) - The pre-flight request and the request transactions as example. - Header sample from a Pre-flight request: ``` -H "Access-Control-Request-Headers: authorization" -H "Access-Control-Request-Method: POST" ```

@SimonCropp sample test created: https://github.com/getsentry/sentry-dotnet/pull/1874

> Looking over this closer, it seems that this change would make both branches of this function do the same thing. > > ```cs > private static ISpan? GetParent(SentryEFSpanType type,...