Luca Ongaro

Yes, contributions like yours are very welcome :) My concern is mostly to avoid big breaking changes with limited benefit. It's acceptable to add some breaking change in a major...

I will close this PR, but the conversation is still very relevant to implement the strongly typed interface of the next major release.

Hi @oiver555 , MiniSearch follows semantic versioning: breaking changes are only introduced with major releases. In other words, as long as the first version number does not change (the `x`...

Hi @ItamarGronich , thanks a lot for opening this issue and for sending a pull request. Allow me the time to reproduce the bug and fully understand the implications (I...

@ItamarGronich I followed the steps for reproduction (thanks a lot for providing them, very helpful 👍 ). I indeed get an error when running `npm run startrepor`: ``` error TS1479:...

@ItamarGronich I believe the issue is that when `"type": "commonjs"` in `package.json`, TypeScript expects all source files with extension `.ts` in the application to be CommonJS (and ES module files...

Uhm you are right, this is more complex than I hoped... Relevant documentation: - https://www.typescriptlang.org/docs/handbook/modules/theory.html#the-module-output-format - https://www.typescriptlang.org/docs/handbook/modules/reference.html#the-module-compiler-option

This seems to be a solution: https://github.com/lucaong/minisearch/pull/258 It seems that the actual content of the declaration file does not matter, but its extension does: a `.d.ts` file assumes the presence...

Unfortunately, I cannot seem to get the `@rollup/plugin-typescript` to generate a single `.d.ts` declaration file: it creates separate files for each source file instead. That's why I use `rollup-plugin-dts`, which...

Same as what @xtr3me noted: we also have issues printing over CUPS, and reverting to `1.7` works. If it helps, printing over CUPS gives the following error (which is printed...