lucagiove

Results 16 comments of lucagiove

Look nice what about writing this as part of the library documentation? Maybe some example how to do basic operations with this Library?

I've updated the doc but cookies are not well documented and not in all parts (eg. updates session doc)

Maybe we can just use `Http Get` without Request and take advantage of https://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#implicit-argument-types-based-on-default-values as @mkorpela suggested

Or embedding the verb in the keyword itself for Http ${verb} On Session https://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#embedding-arguments-into-keyword-names

You are right currently this library is reducing the original library api only to single float variable instead of a tuple, I'll have a look into this.

Interesting the approach of looking at headers for the length. By the way I don't think your implementation is clean enough to be merged and if the size is higher...

No it's not acceptable as well but I'll think about it, maybe logging could be disabled by a global library property definitely not for each keyword. I'll think about it...

Thanks for the suggestion of passing multiple expected values, it could be an enhancement. I'm not sure I understood this instead: > we would love to have the response than...

As said you could pass 'any' as expected status in order not to let the keyword fail.

That's most probably because you're using the data= parameter instead of json= try to swap those parameters.