Luca Giacchino

Results 18 comments of Luca Giacchino

@adamretter That's a great point. In general, this should work with any reversible data transformation. For encryption specifically, RocksDB already supports pluggable providers, but there could be other uses.

@mrambacher Thanks for your feedback! I started by splitting the PR into multiple commits. I'll work on the remaining items.

Addressed some of the comments above and rebased branch. There are two additional changes from the previous version. - compressor.h: added DictCompressionSupported method in Compressor (needed after PR #7619). -...

Absolutely. Performance is a key requirement for this feature. From the data I've collected so far with db_bench (readrandom and readrandomwriterandom workloads), the performance difference is in general

I ran fillseq and readrandom benchmarks, comparing the PR against the previous commit on the main branch. Workload parameters: 16-byte keys, 256-byte values, 4kB blocks, ZSTD/LZ4 compression, db on /dev/shm,...

We observed the same issue, and we found it's related to [JEP 416](https://openjdk.org/jeps/416). As mentioned in the JEP, it's possible to use the old implementation with -Djdk.reflect.useDirectMethodHandle=false. Following that suggestion,...

> By the way, we are finally very interested in this line of features. Thanks for working on it! That's great, thank you! I'll work on the items above and...

Code is rebased on latest main based RocksDB 8.6.7 (the previous code was based on RocksDB 8.1.1). One note regarding ZSTDContext - ZSTDContext replaces CompressionContext, making it Compressor-specific. A Compressor...

Code is rebased on latest main based RocksDB 8.6.7 (the previous code was based on RocksDB 8.1.1). I kept some of the changes in separate commits for ease of review....

@jkatz I think clang is not applying `__attribute__((target("avx512fp16")))` I tested on an m7i instance (where `-march=native` includes `-mavx512fp16`) with clang-15 - Build pgvector with the default Makefile (which has` -march=native`...