ammonia-wasm

ammonia-wasm copied to clipboard

The current version of Ammonia that is used by this package is quite a bit behind (This is on version `3.1.0`). Please try to update to the latest version, if...

prettykool

Incorrect type of 'setTagAttributeValues' property

1

The `setTagAttributeValues` property of the `AmmoniaBuilder` class expects a value of type `Map` [[link](https://github.com/lucacasonato/ammonia-wasm/blob/main/mod.ts#L213)]. But the same property in [rust-ammonia](https://docs.rs/ammonia/latest/ammonia/) expects the type `Map`[[link](https://docs.rs/ammonia/latest/ammonia/struct.Builder.html#method.set_tag_attribute_values)]. This leads to an error when...

abd6982

abd6982

Document need to run `init` better

1

Please document the need to run `init` better. Readme has it in the example, but that's very easy to skip. Especially, if like me, you were reading https://doc.deno.land/https://deno.land/x/[email protected]/mod.ts in the...

tv42

"How to use" example code incorrect?

1

I had to change the last line to of the code to the following, otherwise the new settings created with `AmmoniaBuilder` are not used. ``` cleaner.clean("foobar"); ```

wanacode

[This line](https://deno.land/x/[email protected]/mod.ts?source#L343) constructs the object for tagAttributeValues improperly which causes this feature of Ammonia to not work with whitelisting specific values for attributes. All it needs is for [this line](https://deno.land/x/[email protected]/mod.ts?source#L349)...

firecakes