Results 345 comments of Luca Bruno

Yes: https://github.com/tikv/rust-prometheus/blob/8b462b194565d35e84def2d27ca8efd4d395a7c9/src/value.rs#L87-L106 But, once again, `f64` is really how the whole Prometheus universe works.

Interesting, I'll need to read a bit more about the underlying logic. Does this have an equivalent in Go world (or any other client library)?

@MrCroxx thanks for the patch! Let's bump the MSRV, 1.60 sounds like a good target. Could you please do that in a separate PR? I'll review and merge that one,...

Thanks for the report. Sounds like a good idea! I'll be happy to review a patch doing this if anybody wants to tackle it.

Thanks for the patch. I'm still slightly unconvinced on the `from_arc_*()` methods, but let me sleep a bit longer on that. The rest of this PR looks good, although a...

I meant on the proposed API for the `prometheus` crate. Perhaps I'm misunderstanding something, but I think that currently `prometheus::value::Value` is not a public type, because the module `prometheus::value` is...

@moustafab I don't think anybody is working on this right now, feel free to go ahead and submit a PR whenever you are ready for a review.

That's great to see! It looks like there is large low-level rework behind these changes, that is dropping the protobuf internal structures, am I reading that right? If so, is...

For reference, we are already starting to see users stumbling on old-Prometheus vs OpenMetrics incompatibilities (eg. https://github.com/tikv/rust-prometheus/issues/425 on timestamps format). Making a clearer split between old-Prometheus and new-OpenMetrics may possibly...

I'm not sure where this is coming from but I think somebody manually pointed it at this repo; if so, can you please comment back here?