rust-prometheus
rust-prometheus copied to clipboard
tikv
feat: export inner MetricVecBuilder structs
Signed-off-by: MrCroxx [email protected]
This PR exports MetricVecBuilder types, with which users can easily build customized tools.
In risingwave#9756 I built self-managed metrics generic types with the inner builder types. IMO exporting the inner builder helps a lot. Is It okay to export them to all user or is there any better way to achieve it? Thanks a lot. 🙏
Seems a new version of indirect dependency requires the new rust version. 🤔
The changes look fine.
Seems a new version of indirect dependency requires the new rust version. thinking
The dev dependency rayon 1.7 requires Rust 1.59 and the indirect dependency
security-framework v2.9.0 now requires Rust 1.60.
$ cargo tree --target all -i security-framework --features push
security-framework v2.9.0
└── native-tls v0.2.11
├── hyper-tls v0.5.0
│ └── reqwest v0.11.17
│ └── prometheus v0.13.3 (/projects/various/rust-prometheus)
├── reqwest v0.11.17 (*)
└── tokio-native-tls v0.3.1
├── hyper-tls v0.5.0 (*)
└── reqwest v0.11.17 (*)
@nickelc Thanks for help. Should I pin the dependency to the version that meets the MSRV(1.57) requires or update MSRV to a higher version?
@MrCroxx thanks for the patch! Let's bump the MSRV, 1.60 sounds like a good target. Could you please do that in a separate PR? I'll review and merge that one, so that we can first unblock CI and then get to the rest of changes later.
@nickelc Could you please do that in a separate PR? I'll review and merge that one, so that we can first unblock CI and then get to the rest of changes later.
Sure~
Done with #491 .
Besides, would you like to publish a new version of this lib after this PR is merged?