Carlos Martins

Results 107 comments of Carlos Martins

lol there's something weird going on with the auto-assigner. I don't think it should have assigned @puneetlath, because of [this comment](https://github.com/Expensify/App/issues/11427#issuecomment-1266144736)

I agree. @tienifr [proposal](https://github.com/Expensify/App/issues/11427#issuecomment-1275786664) looks good, but we should account for [this style](https://github.com/Expensify/App/issues/11427#issuecomment-1277829883) change.

Hey @juaal12 @kivohin! Is there any update on merging this PR? Thank you so much!

I'll review the PR as well, since it touches many of the Simplified Collect pages I was involved with and I wanna make sure the logic still works as intended.

I think we could demote this to NAB, but I'll leave it up to @francoisl

Checking off https://github.com/Expensify/App/issues/36038. Demoted to NAB

## Reviewer Checklist - [x] I have verified the author checklist is complete (all boxes are checked off). - [x] I verified the correct issue is linked in the `###...

I said this in [Slack](https://expensify.slack.com/archives/C03TQ48KC/p1714421087411779), but I think we should get rid of the switch statement, create individual keys and use [translateIfPhraseKey](https://github.com/Expensify/App/blob/41ed79dd3542fef12993cfa5775f5130db79e0c2/src/libs/Localize/index.ts#L195) instead. Not gonna block this PR since the...

Demoted https://github.com/Expensify/App/issues/40126