App icon indicating copy to clipboard operation
App copied to clipboard

Published 20 hours ago • verified publisher icon Expensify

Deploy Checklist: New Expensify 2024-04-10

Open github-actions[bot] opened this issue 10 months ago • 19 comments

Release Version: 1.4.62-6 Compare Changes: https://github.com/Expensify/App/compare/production...staging

This release contains changes from the following pull requests:

  • [x] https://github.com/Expensify/App/pull/13767
  • [x] https://github.com/Expensify/App/pull/37047
  • [x] https://github.com/Expensify/App/pull/37175
  • [x] https://github.com/Expensify/App/pull/37214
  • [x] https://github.com/Expensify/App/pull/37641
  • [x] https://github.com/Expensify/App/pull/37961
  • [x] https://github.com/Expensify/App/pull/38400
  • [x] https://github.com/Expensify/App/pull/38551
  • [ ] https://github.com/Expensify/App/pull/38730
  • [ ] https://github.com/Expensify/App/pull/38947
  • [x] https://github.com/Expensify/App/pull/39031
  • [x] https://github.com/Expensify/App/pull/39141
  • [x] https://github.com/Expensify/App/pull/39175
  • [ ] https://github.com/Expensify/App/pull/39190
  • [x] https://github.com/Expensify/App/pull/39209
  • [x] https://github.com/Expensify/App/pull/39226
  • [ ] https://github.com/Expensify/App/pull/39239
  • [x] https://github.com/Expensify/App/pull/39311
  • [x] https://github.com/Expensify/App/pull/39328
  • [ ] https://github.com/Expensify/App/pull/39372
  • [x] https://github.com/Expensify/App/pull/39373
  • [x] https://github.com/Expensify/App/pull/39387
  • [ ] https://github.com/Expensify/App/pull/39394
  • [ ] https://github.com/Expensify/App/pull/39454
  • [x] https://github.com/Expensify/App/pull/39522
  • [x] https://github.com/Expensify/App/pull/39553
  • [ ] https://github.com/Expensify/App/pull/39562
  • [x] https://github.com/Expensify/App/pull/39582
  • [x] https://github.com/Expensify/App/pull/39584
  • [x] https://github.com/Expensify/App/pull/39585
  • [x] https://github.com/Expensify/App/pull/39586
  • [x] https://github.com/Expensify/App/pull/39589
  • [x] https://github.com/Expensify/App/pull/39594
  • [x] https://github.com/Expensify/App/pull/39604
  • [x] https://github.com/Expensify/App/pull/39619
  • [x] https://github.com/Expensify/App/pull/39627
  • [x] https://github.com/Expensify/App/pull/39643
  • [x] https://github.com/Expensify/App/pull/39651
  • [x] https://github.com/Expensify/App/pull/39652
  • [x] https://github.com/Expensify/App/pull/39664
  • [x] https://github.com/Expensify/App/pull/39666
  • [x] https://github.com/Expensify/App/pull/39667
  • [x] https://github.com/Expensify/App/pull/39669
  • [x] https://github.com/Expensify/App/pull/39684
  • [x] https://github.com/Expensify/App/pull/39688
  • [x] https://github.com/Expensify/App/pull/39723
  • [x] https://github.com/Expensify/App/pull/39740
  • [x] https://github.com/Expensify/App/pull/39744
  • [x] https://github.com/Expensify/App/pull/39747
  • [x] https://github.com/Expensify/App/pull/39749
  • [x] https://github.com/Expensify/App/pull/39761
  • [x] https://github.com/Expensify/App/pull/39786
  • [ ] https://github.com/Expensify/App/pull/39788
  • [x] https://github.com/Expensify/App/pull/39789
  • [x] https://github.com/Expensify/App/pull/39801
  • [x] https://github.com/Expensify/App/pull/39826
  • [x] https://github.com/Expensify/App/pull/39830
  • [x] https://github.com/Expensify/App/pull/39854
  • [x] https://github.com/Expensify/App/pull/39860
  • [x] https://github.com/Expensify/App/pull/39893
  • [x] https://github.com/Expensify/App/pull/39897
  • [x] https://github.com/Expensify/App/pull/39901
  • [x] https://github.com/Expensify/App/pull/39941
  • [x] https://github.com/Expensify/App/pull/39943
  • [x] https://github.com/Expensify/App/pull/39948
  • [x] https://github.com/Expensify/App/pull/39952
  • [x] https://github.com/Expensify/App/pull/39964
  • [x] https://github.com/Expensify/App/pull/39990
  • [x] https://github.com/Expensify/App/pull/40008
  • [x] https://github.com/Expensify/App/pull/40049
  • [x] https://github.com/Expensify/App/pull/40079
  • [x] https://github.com/Expensify/App/pull/40096
  • [x] https://github.com/Expensify/App/pull/40109
  • [ ] https://github.com/Expensify/App/pull/40180
  • [ ] https://github.com/Expensify/App/pull/40184

Deploy Blockers:

  • [x] https://github.com/Expensify/App/issues/39982
  • [x] https://github.com/Expensify/App/issues/40027
  • [x] https://github.com/Expensify/App/issues/40028
  • [x] https://github.com/Expensify/App/issues/40029
  • [x] https://github.com/Expensify/App/issues/40034
  • [x] https://github.com/Expensify/App/issues/40035
  • [x] https://github.com/Expensify/App/issues/40036
  • [ ] https://github.com/Expensify/App/issues/40037
  • [x] https://github.com/Expensify/App/issues/40039
  • [ ] https://github.com/Expensify/App/issues/40040
  • [x] https://github.com/Expensify/App/issues/40041
  • [x] https://github.com/Expensify/App/issues/40042
  • [x] https://github.com/Expensify/App/issues/40043
  • [x] https://github.com/Expensify/App/issues/40045
  • [x] https://github.com/Expensify/App/issues/40047
  • [ ] https://github.com/Expensify/App/issues/40048
  • [x] https://github.com/Expensify/App/issues/40050
  • [x] https://github.com/Expensify/App/issues/40052
  • [x] https://github.com/Expensify/App/issues/40053
  • [x] https://github.com/Expensify/App/issues/40055
  • [x] https://github.com/Expensify/App/issues/40056
  • [ ] https://github.com/Expensify/App/issues/40057
  • [x] https://github.com/Expensify/App/issues/40067
  • [ ] https://github.com/Expensify/App/issues/40076
  • [ ] https://github.com/Expensify/App/issues/40077
  • [x] https://github.com/Expensify/App/issues/40078
  • [x] https://github.com/Expensify/App/issues/40080
  • [x] https://github.com/Expensify/App/issues/40081
  • [x] https://github.com/Expensify/App/issues/40082
  • [ ] https://github.com/Expensify/App/issues/40084
  • [x] https://github.com/Expensify/App/issues/40085
  • [x] https://github.com/Expensify/App/issues/40086
  • [ ] https://github.com/Expensify/App/issues/40087
  • [x] https://github.com/Expensify/App/issues/40093
  • [x] https://github.com/Expensify/App/issues/40105
  • [ ] https://github.com/Expensify/App/issues/40107
  • [ ] https://github.com/Expensify/App/issues/40108
  • [ ] https://github.com/Expensify/App/issues/40123
  • [x] https://github.com/Expensify/App/issues/40124
  • [x] https://github.com/Expensify/App/issues/40126

Deployer verifications:

  • [ ] I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • [ ] I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • [ ] I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

github-actions[bot] avatar Apr 10 '24 17:04 github-actions[bot]

Checked off as they don't need to be QA'd:

  • https://github.com/Expensify/App/pull/39740
  • https://github.com/Expensify/App/pull/39744
  • https://github.com/Expensify/App/pull/39747
  • https://github.com/Expensify/App/pull/39749

Julesssss avatar Apr 10 '24 17:04 Julesssss

Checking off the PROD PRs (help.expensify.com) https://github.com/Expensify/App/pull/39387 https://github.com/Expensify/App/pull/39664 https://github.com/Expensify/App/pull/39666 https://github.com/Expensify/App/pull/39667 https://github.com/Expensify/App/pull/39669 https://github.com/Expensify/App/pull/39826

kavimuru avatar Apr 10 '24 18:04 kavimuru

Demoting https://github.com/Expensify/App/issues/40027

blimpich avatar Apr 10 '24 19:04 blimpich

https://github.com/Expensify/App/issues/40050 is intended behavior

roryabraham avatar Apr 10 '24 23:04 roryabraham

https://github.com/Expensify/App/issues/40082 is not a blocker https://github.com/Expensify/App/issues/39982 is not a blocker https://github.com/Expensify/App/issues/40052 is not a blocker

Julesssss avatar Apr 11 '24 10:04 Julesssss

Closed https://github.com/Expensify/App/issues/40093

twisterdotcom avatar Apr 11 '24 10:04 twisterdotcom

https://github.com/Expensify/App/issues/40053 is minor and related to a new feature (live-markdown) https://github.com/Expensify/App/issues/40086 is a console log, demoted

Julesssss avatar Apr 11 '24 12:04 Julesssss

https://github.com/Expensify/App/issues/40085 demoted as not critical

Julesssss avatar Apr 11 '24 12:04 Julesssss

https://github.com/Expensify/App/issues/40067 and https://github.com/Expensify/App/issues/40029 fixed by this CP: https://github.com/Expensify/App/pull/40079

Julesssss avatar Apr 11 '24 12:04 Julesssss

https://github.com/Expensify/App/issues/40036 fixed by https://github.com/Expensify/App/pull/40049

Julesssss avatar Apr 11 '24 12:04 Julesssss

Regression is 3% left. #38730 failing with #40103 #38947 failing with #40048 #39190 failing with #40029 #39239 failing with #40043 #39372 failing with #40041 #39723 failing with #40051 repro in PROD, checking it off #39788 failing with #40052

kavimuru avatar Apr 11 '24 13:04 kavimuru

Checked off https://github.com/Expensify/App/issues/40081 as it doesn't seem like a big enough issue to be a blocker

Beamanator avatar Apr 11 '24 14:04 Beamanator

https://github.com/Expensify/App/issues/40055 fixed by https://github.com/Expensify/App/pull/40096

Julesssss avatar Apr 11 '24 15:04 Julesssss

Demoted https://github.com/Expensify/App/issues/40126

luacmartins avatar Apr 11 '24 16:04 luacmartins

Demoted https://github.com/Expensify/App/issues/40035

deetergp avatar Apr 11 '24 16:04 deetergp

Regression is just 14 steps left. Unchecked PRs: #39394 we need more details about the QA steps and not sure it is internal. Comment #38730 failing with #40103 #38947 failing with #40048 #39190 failing with #40029 #39239 failing with #40043 #39372 failing with #40041 #39454 failing with #40108 #39562 failing with #40036 #39788 failing with #40052

kavimuru avatar Apr 11 '24 17:04 kavimuru

Regression is completed. Unchecked PRs: #39394 we need more details about the QA steps and not sure it is internal. Comment #38730 failing with #40103 #38947 failing with #40048 #39190 failing with #40029 #39239 failing with #40043 #39372 failing with #40041 #39454 failing with #40108 #39562 failing with #40036 #39788 failing with #40052 Open Blockers: https://github.com/Expensify/App/issues/40034 #40037 https://github.com/Expensify/App/issues/40040 https://github.com/Expensify/App/issues/40041 https://github.com/Expensify/App/issues/40048 https://github.com/Expensify/App/issues/40057 https://github.com/Expensify/App/issues/40076 https://github.com/Expensify/App/issues/40077 https://github.com/Expensify/App/issues/40078 https://github.com/Expensify/App/issues/40084 https://github.com/Expensify/App/issues/40087 https://github.com/Expensify/App/issues/40105 https://github.com/Expensify/App/issues/40107 https://github.com/Expensify/App/issues/40108 https://github.com/Expensify/App/issues/40123 https://github.com/Expensify/App/issues/40124

kavimuru avatar Apr 11 '24 18:04 kavimuru

Demoting #40105

rlinoz avatar Apr 11 '24 21:04 rlinoz

This CP'd PR fixed https://github.com/Expensify/App/issues/40080, both are checked off the list now

Beamanator avatar Apr 12 '24 10:04 Beamanator

confirmed https://github.com/Expensify/App/issues/40077 is fixed, checking it off

roryabraham avatar Apr 16 '24 23:04 roryabraham

ok, so we've been talking through this checklist in #fireroom-2024-04-17-app-deploy. Ultimately it has not gone very smoothly, and that's largely due to inconsistently reproducible but critical issues that have happened in concert with enabling the new architecture.

Our plan is to ship this release on all platforms except Android, where we're aware of a number of unresolved critical issues. This will allow us to continue shipping code on all other platforms and prevent the monster release that will follow this one from growing any more cumbersome than it already promises to be.

roryabraham avatar Apr 18 '24 02:04 roryabraham

https://github.com/Expensify/App/issues/40360 is fixed by https://github.com/Expensify/App/pull/40383 in 1.4.62-15 (without re-introducing https://github.com/Expensify/App/issues/40077)

roryabraham avatar Apr 18 '24 02:04 roryabraham

https://github.com/Expensify/App/issues/40048 and https://github.com/Expensify/App/issues/40108 share the same root cause, and remain unresolved. These are Android-only issues, and as mentioned above I'm going to check them off. They will continue to have the deploy blocker label, so should appear as deploy blockers in the next checklist

roryabraham avatar Apr 18 '24 02:04 roryabraham

There's only one fresh crash SensorSetter.sensorSetter

Fatal Exception: com.facebook.jni.CppException Exception in HostFunction: Error: Exception in HostFunction: at _maybeFlushUIUpdatesQueue (native) at anonymous (JavaScript:1:405) at callMicrotasksOnUIThread (JavaScript:1:61) at anonymous (JavaScript:1:406)

com.swmansion.reanimated.nativeProxy.SensorSetter.sensorSetter (SensorSetter.java)

It's only happened to a single user on 1.4.62-7 so I think we're okay here -

thienlnam avatar Apr 18 '24 04:04 thienlnam

:shipit:

thienlnam avatar Apr 18 '24 04:04 thienlnam