lsiepel

Results 590 comments of lsiepel

I'm unable to asses if these changed modes are good. Code is fine. Need @Skinah to determine if this is ok to merge. In the mean time it would be...

@valdisrigdon do you need anything to proceed with this PR?

> ve some help merging the suggested changes and getting this over the line. I've been running with this build and it's been super stable. Anything specific you need help...

Please rebase now the other pr is merged.

Nice to have some tests added to the codebase. Did you manage to reproduce the issue with theses tests? Any change you can proceed with this?

Please rebase now the other PR is merged. You might need to look into the thingtypeversion as version 1 is allready merged. (did not look if they are about the...

Did you fix all the review comments from the previous PR, like the textual config and oauth? Can you also fix the DCO?

@bobadair are you able to fix the DCO and build? I might review this PR, just checking if you are able to continue.

I guess this should also fixes: https://github.com/openhab/openhab-addons/issues/12534 due to proper use of thread pool. And does it fix https://github.com/openhab/openhab-addons/issues/10400 ?

Some fixes might allready be added as we jumped to java 17 and bulk PR's have been merged.