openhab-addons
openhab-addons copied to clipboard
openhab
[ipcamera] Fix Reolink Duo Floodlight whiteLED Channel
Updated whiteLED channel for reolink ipcamera so that when the light is turned on, it will stay on forever and if the light is turned off, it will stay off forever. This is achieved by setting the floodlight mode to "Always On at Night" when the floodlight is turned on and to Off when the floodlight is turned off. Prior to this change, the mode would be set to Auto when turning the floodlight off and to Off when setting the floodlight ON and then back to Auto if you change the brightness via the dimmer.
This was tested and confirmed on a Reolink Duo Floodlight POE camera and is working well for me. I believe this setting would be more ideal for most users but I could be wrong. I just thought it was odd that the floodlight wouldn't stay on longer than 3 minutes after the brightness was set to 100. The same thing probably could have been achieved if mode is set to 0 for all 3 settings.
Signed-off-by: Simmon Yau [email protected]
I'm unable to asses if these changed modes are good. Code is fine. Need @Skinah to determine if this is ok to merge. In the mean time it would be nice if you can fix the DCO.
I'm unable to asses if these changed modes are good. Code is fine. Need @Skinah to determine if this is ok to merge. In the mean time it would be nice if you can fix the DCO.
Done.
LGTM I am not able to test as I don't own any Reolink cameras so thanks for the testing and changes you have made.
