Gerwin Klein

Results 521 comments of Gerwin Klein

The fall-through violations seem to be in generated code -- we could automatically add the `// fall through` comment in the generator to indicate that this is on purpose.

Right, that's actually what that specific fall through is for: to guard for the cases where there is no `return` or `throw` and the scan just continues. Do we get...

I’m not a big fan of storing those kinds of things anywhere externally, esp not if that account and key has my name attached. Travis is a high value target...

We could do that. Would it be easier to store the snapshots as github build artefacts with each build?

I'll have a look at how much work it would be to set up. @regisd, @sarowe do you have any opinions on this?

In theory the randomness could lead to a test that does not always fail, in practice that happens rarely, although it does happen. How often it happens depends on the...

It seems to be working fine, and it's at least for me way easier to find good tests to write, so I'll continue working on this a bit and add...

#687 bring this to reasonably comprehensive tests for `IntCharSet`, `StateSet`, and `CharClasses`. I'll see if it make sense to do something on `RegExp` next, and if that is successful, on...

This does look like an actual jflex bug. Thanks for reporting it, I'll take a closer look in the next few days.

**Commented by vbstudio on 2013-03-13 22:51 UTC** actually java regards a sole \r as new line aswell