Gerwin Klein

Results 521 comments of Gerwin Klein

I think this might have uncovered an actual bug, at least so far it doesn't look like anything to do with the test driver. It'd be great if we could...

Hm, actually, thinking more about it, it might be an issue with the test after all. We're asserting ```java assertThat(classes.getClassCode(ch)).isNotEqualTo(cCode); ``` where `ch` is a code point in the string....

Sorry, no super bright ideas on this one. Basically, for caseless you'd need to check that if the class is equal the code point `c` and the code point in...

This is looking mostly good from my side modulo the still unresolved comments (the ones back from 20 Jun). Nice to see the build passing!

Sorry, things have been busy lately. I'm happy with the StateSet interface and the new changes. What about the [comment](https://github.com/jflex-de/jflex/pull/953#discussion_r901164466) on `assertThat(setPre.contains(set)).isFalse();`? When that is addressed, I think we are...

@regisd, @sarowe would you be happy for me to go ahead with this?

**Commented by rfscholte on 2010-10-23 09:02 UTC** And/or a try/finally statement around the switch to catch them all, no matter what. Only with one of these solutions I will be...

**Commented by lsf37 on 2007-07-29 00:52 UTC** Logged In: YES user_id=93534 Originator: NO Hi John, these two should already be supported if you use the file skeleton.nested as skeleton file...

**Commented by jafl on 2007-07-30 19:49 UTC** Logged In: YES user_id=1439262 Originator: YES Actually, skeleton.nested provides a stream stack, not a state stack. I will work on implementing a similar...