Lasse R.H. Nielsen

Results 1593 comments of Lasse R.H. Nielsen

If this is restricted to top-level functions named `getX` and `setX`, it's probably fairly safe. Those are badly named already, and could use some help. Should it apply to `_getX`...

The lint seems to be about renaming parameters if you inherit DartDoc that might refer to the parameter by name. (Does it only trigger if the DartDoc does refer to...

The reference to DartDoc comes from [the lint itself](https://dart-lang.github.io/linter/lints/avoid_renaming_method_parameters.html), as the lint's only justification. If that's to be trusted, ```dart class A { /// Do something with [a]. void a(A...

Even function literals are not free, you have to allocate a closure. I hope we are fairly efficient at that, so slightly faster than doing a string interpolation. But I...

Is this the `TypeChecker` from `package:source_gen`? (If so, the issue would fit better in https://github.com/dart-lang/source_gen/issues).

Being a *little* specialized is fine for `package:collection`. The package is there to make things available that some amount of people will eventually need, as opposed to the SDK where...

Good point. The behavior is equivalent only to the default behavior of `[]=`. The documentation should be rewritten.

If we are going to do *more* than just this class, we should probably do it in a separate package. But, if RxDart exists, and I'm sure there are other...

Not clear what should be changed. Can you elaborate?